Compare commits

..

1 Commits

Author SHA1 Message Date
Brock H Caldwell
dbcc24c49f fix(DownloadOptionEvaluator): bad logic checking filters
Some checks failed
SonarQube Scan / SonarQube Trigger (push) Failing after 13s
2026-02-08 12:34:50 -06:00

View File

@@ -21,9 +21,10 @@ class DownloadOptionEvaluator
return false;
}
if (false === $this->validateSize($result, $filter)) {
return false;
}
// todo: This is arbitrary- revisit in the future
//if (false === $this->validateSize($result, $filter)) {
// return false;
//}
if (false === $this->validateDownloadUrl($result->url)) {
return false;
@@ -51,15 +52,15 @@ class DownloadOptionEvaluator
$valid = false;
}
if (null !== $filter->codec && in_array($result->codec, $filter->codec)) {
if (null !== $filter->codec && !in_array($result->codec, $filter->codec)) {
$valid = false;
}
if (null !== $filter->quality && in_array($result->quality, $filter->quality)) {
if (null !== $filter->quality && !in_array($result->quality, $filter->quality)) {
$valid = false;
}
if (null !== $filter->provider && in_array($result->provider, $filter->provider)) {
if (null !== $filter->provider && !in_array($result->provider, $filter->provider)) {
$valid = false;
}