home/torsearch
1
0
Fork 0
Code Issues 22 Pull Requests 1 Actions 3 Packages Projects 4 Releases Wiki Activity

fix(DownloadOptionEvaluator): bad logic checking filters
Some checks failed
SonarQube Scan / SonarQube Trigger (push) Failing after -50s
Details

Browse Source
This commit is contained in:
Brock H Caldwell
2026-02-08 12:34:50 -06:00
parent 939b059872
commit dbcc24c49f
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Download/DownloadOptionEvaluator.php
View File

@@ -21,9 +21,10 @@ class DownloadOptionEvaluator
return false;
}
if (false === $this->validateSize($result, $filter)) {
return false;
}
// todo: This is arbitrary- revisit in the future
//if (false === $this->validateSize($result, $filter)) {
// return false;
//}
if (false === $this->validateDownloadUrl($result->url)) {
return false;
@@ -51,15 +52,15 @@ class DownloadOptionEvaluator
$valid = false;
}
if (null !== $filter->codec && in_array($result->codec, $filter->codec)) {
if (null !== $filter->codec && !in_array($result->codec, $filter->codec)) {
$valid = false;
}
if (null !== $filter->quality && in_array($result->quality, $filter->quality)) {
if (null !== $filter->quality && !in_array($result->quality, $filter->quality)) {
$valid = false;
}
if (null !== $filter->provider && in_array($result->provider, $filter->provider)) {
if (null !== $filter->provider && !in_array($result->provider, $filter->provider)) {
$valid = false;
}